lberki

If all we do is internal reviews, we are not really an open source project, are we? My understanding is that we decided to flip the flag instead and start...

My guess is that this has been fixed in https://github.com/bazelbuild/bazel/pull/22100 and cherry-picked into 7.2.0 as `f6618782df1521e674061d3b6a6bb973ed78f591`. Assigning to @Wyverald on the off chance he notices something I didn't.

Nevermind, my bad. I didn't realize this occurred with 7.2.0-rc1. Let's see what @Wyverald has to say then!

Taking about a zillionth look at the code: in what case is it possible that the `state.workerExecutorService.isShutdown()` check in line 143 returns true? AFAIU the executor is shut down in...

@emaxx-google do you have a way of testing experimental Bazel versions for the occurrence of this bug? It would be nice if we could "battle-test" changes to fix this issue...

Changing `.bazelversion` would be good enough. I think what could work is the following: 1. @Wyverald rebases the tentative fix on top of `7.2.0rc1` 2. He pushes it through CI...

> > 1. When `.close()` is called on the `SkyKeyComputeState` by Skyframe. However, the documentation of `removalListener()` says that the removal listener is called _after_ the entry is removed from...

@emaxx-google can you get us a stack trace? (`jstack` / SIGINT / `Ctrl-\` all work, although I don't know whether any of those is feasible in your CI setup)

@emaxx-google Can you try your CQ with version `9cbbd7d2c9b783f80a816b188ac3a7a7025bdd1f`? It's essentially #22215 rebased and whereas I'm not in love with it for the same reasons @Wyverald isn't, it would be...

I don't have any suggestion other than to rig up a stress test (while true do run Bazel build and do mean things to it; done) and see if it...