lberki
lberki
Indeed, I didn't realize `-c opt` also compresses the binary more. 62MB for me on Linux instead of 98MB (the 205MB number is unchanged, though)
I added some comments, but man, is this change huge. Can you split it up somehow so that I don't forget the first file I looked at before I reach...
There are two, mostly equally valid ways to make things right: one can either do what you are doing in this change and commit to the "bytes as Latin-1" approach...
@coeuvre @justinhorvitz for opinions
Yeah, I agree that if we go with the "use proper UTF-8" approach, Googlers are in a better position to do so. In fact, there is a change from a...
Review process: reviewed e54c6fbd39a661a5a0e68ed00fea39120ae1c91a , no comments other than those of @tjgq 's .
9eb4e1d83e1f9935f28569afcc167d7ef99689cc reviewed.
4a6e219850e135a5cc67760559283822644d4559 reviewed.
Okay, I'm done with the review. That's was a LOT.
To get an early signal on how difficult it would be to update Google-internal code after merging this pull request, I ran our presubmit battery and it ended up pleasantly...