lberki
lberki
@Wyverald WDYT? This is the best I could do. It's not *bad* and I can almost keep the state in my head. I still hate `Exchanger` (but I have no...
Discarding in favor of #22215 and #22100.
Now that platform threads are not used anymore, why do we even need an `ExecutorService` and monkey around with futures? I could imagine an approach where we'd directly store a...
I think I have an explanation for the deadlock you found on #22110. you interrupt the worker thread, then the `InterruptedException` is caught in the `catch (Throwable e)` in line...
I take the "unbounded queue" idea back. The only case where a deadlock should happen is when one thread is waiting in `.put()` / `.take()` and the other doesn't ever...
My apologies; instead of "`finally` clause", I should have said `catch (Throwable e)`. I took your attempt and ran with it and created https://github.com/bazelbuild/bazel/pull/22139 . WDYT? At the time I'm...
I added some comments, but I think that they are just asking for reassurance and the code works as it is today. I propose the following course of action: 1....
I thought it was but you're right -- it seems to not have been: https://github.com/bazelbuild/bazel/compare/release-7.1.0...release-7.2.0rc2 *Very* good catch!
Nevermind, it's late here. The fix is de4d519ac52bd6400a016654eb85733ba16ac6f7 and was duly cherry-picked to 7.2.0rc2 as c6cabd8b45c46640f77190d08ba645e49f05a4e9. Please don't tell me that you still see this deadlock in rc2...