lberki
lberki
> @lberki > > > @Wyverald do you know what takes 5 seconds? Initially, I thought that it was because the checksumming and tree traversal run on one thread, but...
@Wyverald mind assigning this review to someone else? I'd have to get up to speed on the intricacies of module extensions etc. to review this change (I should do that...
@555vedant are you volunteering to fix this issue? (Unless @Wyverald disagrees, I'd be delighted.)
cc @ramymedhat
I think that's a reasonable idea (cc @tjgq @coeuvre ); getting the separate tools is a pain and I *hope* that since Bazel needs to link all the code handling...
@ismell brought up an interesting point today: if your level of abstraction is system calls (`readdir()` and `stat()`), you need to issue a Starlark function call for each file /...
Ah, then it's a classical case of us all three thinking that this feature request must obviously mean something, except that we didn't agree upon what "something" meant :) I...
Is running `stat` instead of `sha256sum` a goal or is it just a performance optimization with the tradeoff that sometimes incorrectness is accepted? @ismell 's desire was to not re-fetch...
They would (in fact, @tjgq and myself just ran into this yesterday). This is why I listed mtime, ctime and inode number in my comment above when calculating the space...
For the cc toolchain use case, isn't what we are ultimately interested in the contents? (it looks like @ismell says that hat's the case for them, too, so I think...