lberki

Results 220 comments of lberki

Allow unresolved symlinks inside a tree artifact

I'm not too surprised. `--experimental_allow_unresolved_symlinks` only works for "regular" artifacts not those that are part of `TreeArtifacts`. This is one of the reasons why it's still experimental... /cc @coeuvre @alexjski...

Allow unresolved symlinks inside a tree artifact

After some discussion with @lfpino we came to the conclusion that there are two missing pieces before we can stabilize this: 1. Support on Bazel's RE interface (this is known...

Allow unresolved symlinks inside a tree artifact

@larsrc-google correct; we had a discussion with @tjgq and the outcome was that it's highly non-trivial how to handle them, because technically, each file in tree artifacts could require different...

Allow unresolved symlinks inside a tree artifact

I think it's all of the above: one would need to * Come up with an API to say that symlinks (or some symlinks) in a tree artifact are unresolved...

`bazel build //X:all` records target completion events in the BEP stream with `file://` URIs, but sometimes doesn't write files to disk

@nya3jp does this always happen for `*_host_deps.profile.json` and `*_host_deps.json`? If so, is there something special about how these files are generated? Maybe from an aspect, a top-level aspect, or some...

`bazel build //X:all` records target completion events in the BEP stream with `file://` URIs, but sometimes doesn't write files to disk

That might actually be relevant! The code path to fetch the outputs of aspects is slightly different depending on the value of `--experimental_merged_skyframe_analysis_execution`. @joeleba mind taking a look at this...

`bazel build //X:all` records target completion events in the BEP stream with `file://` URIs, but sometimes doesn't write files to disk

The second alternative it is. Here is a reproduction. As expected, it requires `--experimental_merged_skyframe_analysis_execution` and `--remote_download_outputs=toplevel` . ```shell cat > BUILD slow/BUILD # Unblock analyzing :top wait %1 # Wait...

`bazel build //X:all` records target completion events in the BEP stream with `file://` URIs, but sometimes doesn't write files to disk

That'll be for @coeuvre to decide -- that's definitely the simplest solution although in incurs a performance hit, since the download would start potentially much later than the moment Bazel...

query: expose `is_executable`

Since this is in the twilight zone between all these teams, I'll step in: why is this logic useful for you? This at least doesn't work with aliases (and can't,...

Hard-wire --experimental_sibling_repository_layout to false.

In a last, desperate attempt, I ran the HEAD + downstream projects pipeline and it's surprisingly green: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3753#018e7f5a-9256-492e-8dcf-ccbe3e587943 What fails is the following: * Genuine domain-specific issues: * Bazel (in...