Lawrence Forooghian

Results 95 issues of Lawrence Forooghian

In #1240 we got rid of the Quick testing framework, but we did not get rid of the accompanying Nimble assertions library. We should get rid of this in order...

code-quality

See https://github.com/ably/ably-cocoa/commit/3846d776c74d2433d7f874df99d251f0d1447b3c#diff-3ecd2e7a3e1de92027c84d31b11854cb12de37c2a9fad8d97ea4427abff74704R2775. Understand and fix the issue with the script. ┆Issue is synchronized with this [Jira Task](https://ably.atlassian.net/browse/ECO-4452) by [Unito](https://www.unito.io)

build

When building with Xcode 14, I get the following warnings: > - The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions...

As noticed by maratal here: https://github.com/ably/ably-cocoa/issues/1126#issuecomment-1273234030. ┆Issue is synchronized with this [Jira Task](https://ably.atlassian.net/browse/ECO-4427) by [Unito](https://www.unito.io)

If `self->_encoders[response.MIMEType]` is `nil`, then we'll end up calling the callback with both `time` and `error` being `nil`, which is not a valid behaviour. https://github.com/ably/ably-cocoa/blob/0fe3c59658ce7d0b7181571cdad1f068d4085088/Source/ARTRest.m#L519 We need to handle this...

Although RTP19a comes under RTP19 in the spec the preconditions are not the same. ┆Issue is synchronized with this [Jira Task](https://ably.atlassian.net/browse/ECO-4370) by [Unito](https://www.unito.io)

[Passing `false` when test name suggests it should be `true`]( https://github.com/ably/ably-cocoa/blob/fb60993b111b8e70c231d1f756fd474b7e8c3af0/Spec/Tests/RealtimeClientChannelTests.swift#L3482). Looks like a copy and paste of the test above it. Not looked into it in detail. ┆Issue is...

failing-test

https://test-observability.herokuapp.com/repos/ably/ably-cocoa/test_cases/eaebbab2-8b9f-4204-9c48-17e3cd9c4ca6 `AuthTests.test__144__JWT_and_realtime__when_using_authUrl__when_token_expires__receives_a_40142_error_from_the_server` Split from #1330. ┆Issue is synchronized with this [Jira Task](https://ably.atlassian.net/browse/ECO-4331) by [Unito](https://www.unito.io)

failing-test

Originates from this suggestion: https://github.com/ably/ably-asset-tracking-android/issues/862#issuecomment-1365921656. When investigating that issue, we saw the following log lines: ``` 18-12-22 19:48:58.572: io.ably.lib.transport.WebSocketTransport: send(); action = presence 18-12-22 19:48:58.589: io.ably.lib.transport.WebSocketTransport: send(): presence: {"action":14,"channel":"tracking:bo:22607777","count":0,"flags":0,"msgSerial":1,"presence":[{"data":"{\"rawLocations\":false,\"type\":\"PUBLISHER\"}","action":3}],"timestamp":0} ```...

enhancement

@sacOO7 noticed that the acceptance tests are failing (e.g. [here](https://github.com/ably/ably-ruby/actions/runs/8799287951/job/24148038958?pr=391)) with the following error: ``` OpenSSL::SSL::SSLError: unable to verify the server certificate for "internet-up.ably-realtime.com" ``` Not sure how long this...

bug