Lawrence Forooghian

Understand why `pushchannelsubscription.ts` is in the `BaseRealtime` bundle

1

See comment added to `scripts/moduleReport.ts` in #1497. ┆Issue is synchronized with this [Jira Task](https://ably.atlassian.net/browse/ECO-4190) by [Unito](https://www.unito.io)

Fix the signature of `ProtocolMessage.serialize`

1

See description of #1480, in which I had to add a type assertion to get around the signature of `serialize`: > Fixing a newly-introduced compilation error calling `wsConnection.send` in `WebSocketTransport`...

Either fix `EventEmitter#once` with array of event names, or remove it in v2

2

See https://github.com/ably/ably-js/pull/1453#issuecomment-1775289025. ┆Issue is synchronized with this [Jira Bug](https://ably.atlassian.net/browse/ECO-4180) by [Unito](https://www.unito.io)

Bring presence signatures in line with spec (add `extras` argument)

1

The spec says that `RealtimePresence`’s `enter*`, `update*` and `leave*` methods are meant to accept an optional `extras` argument. We do not support this. To pass extras, you need to pass...

Reconsider usage of `this` in `EventEmitter` listeners

1

See [MMB-328](https://ably.atlassian.net/browse/MMB-328); I've created a corresponding issue here since ideally we'd like to keep the Spaces `EventEmitter` API the same as that of ably-js’s corresponding class (my understanding is that...

`EventEmitter.prototype.once(['event1', 'event2'], listener)` discards `listener`’s identity

1

The case where `once` is passed an array of event names is implemented by wrapping the listener argument in another listener: https://github.com/ably/ably-js/blob/76cc74fcfa66beff40f2a367c8b9b69b8aabd60e/src/common/lib/util/eventemitter.ts#L260-L273 This means that the event emitter does not...

Change internal `.d.ts` files to `.ts`

1

For some reason, the `.d.ts` files used internally in the codebase are not checked by the TypeScript compiler. Some of them contain errors (e.g. referring to non-existent types, performing imports...

The library’s internal `Message` class does not implement the public `Message` interface

1

The `Message` type defined in `src/common/lib/types/message.ts` does not implement the `Message` interface defined in `ably.d.ts`. Many of the properties (e.g. `clientId`) in the internal `Message` type accept `undefined` as a...

When client emits a 40171 error, the underlying auth failure is not exposed to user

1

When the client emits a 40171 error due to a token error without means to renew token (per [RSA4a2](https://sdk.ably.com/builds/ably/specification/main/features/#RSA4a2)), there is no way for the user to find out what...

Many callbacks are potentially invoked with an error that doesn't conform to public API

1

There are a couple of issues here: * Many of our public methods which are meant to emit an `ErrorInfo` (as [defined by our type definitions](https://github.com/ably/ably-js/blob/92003d88d89f5d165748396944cc51bc5d00863f/ably.d.ts#L733-L746)) do not do so...