ably-cocoa icon indicating copy to clipboard operation
ably-cocoa copied to clipboard

Increase minimum supported OS versions to remove warnings when building with Xcode 14

Open lawrence-forooghian opened this issue 1 year ago • 3 comments

When building with Xcode 14, I get the following warnings:

  • The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 11.0 to 16.0.99.
  • The tvOS Simulator deployment target 'TVOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 11.0 to 16.0.99.
  • The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.12, but the range of supported deployment target versions is 10.13 to 13.0.99.

It feels pretty safe to me to remove support for these older OS versions even Apple aren't letting us use it as a deployment target any more, and, in the iOS and tvOS case, there are no simulators available for them. QuintinWillison would this count as a "breaking change" in terms of versioning?

┆Issue is synchronized with this Jira Task by Unito

lawrence-forooghian avatar Oct 20 '22 10:10 lawrence-forooghian

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2851

sync-by-unito[bot] avatar Oct 20 '22 10:10 sync-by-unito[bot]

I definitely think this counts as an incompatible/breaking change to the SDK, so this would be a candidate for us to either "sneak in" in the 1.2 series, or more politely queue up for a v2 major bump. Per our Guidance on Versioning. I don't have strong feelings either way, but others might. Unsure of what impact could be for existing customers, also.

FYI, @mikelee638

QuintinWillison avatar Oct 20 '22 16:10 QuintinWillison

This will be fixed by #1630.

lawrence-forooghian avatar Apr 10 '23 12:04 lawrence-forooghian