Lawrence Forooghian

Results 63 comments of Lawrence Forooghian

@owenpearson this is now ready for re-review. I've addressed your comments and incorporated the latest version of the canonical docstrings. I've also added some review notes to the PR description.

Hi, is there any update on when this fix will be released?

I think this needs to be reviewed as a single thing alongside the migration guide, the writing of which is assigned to me. I’m going to branch from this and...

Started working on migration guide in https://github.com/ably/ably-js/pull/1670.

> Ably-js has fallback mechanisms in order to be able to support older browsers; specifically it supports comet-based connections for browsers that do not support websockets. Each of these fallback...

Raised spec PR https://github.com/ably/specification/pull/183 to add these methods (see justification there). Will address #1598 and #1599 and then implement the spec for v2.

Opened #1640 to implement https://github.com/ably/specification/pull/183. #1598 and #1599 can be done separately.

No longer required, since in https://github.com/ably/ably-js/pull/1663 we restored the `ClientOptions.plugins` mechanism and the direct importing of `vcdiff-decoder`.

We talked about this today. @owenpearson believes it to be a useful piece of functionality. So we're going to: 1. specify its behaviour in the feature spec 2. implement that...