lawnjelly

Results 122 comments of lawnjelly

Once the nitpicks above are done this looks fine to me (the function should take a light `RID` if possible imo). I've tested (reasonably, hard to test every permutation) and...

Could this be a method of `Quat` instead of `Vector3`? It seems slightly counter-intuitive (and difficult for discoverability) to try and put this as a method of `Vector3`. :thinking: @AThousandShips...

> Could be. The downside is that you have to create an empty Quat first, as there is no static method. Do you think it's acceptable? Hmm, certainly worth getting...

Overall this looks great. I'd be tempted to take the plunge and use local variables (e.g. reference) in a few cases where multiple `front()->get()` etc are used, just in order...

> This PR seems to provide a tiny overall speedup (in terms of overall runtime, including startup + shutdown) across an average of 10 runs for each. Standard deviation is...

I'll try and test this out locally once we've solved the closure problem.

Just to confirm, it looks like compiler is pretty good at optimizing out unneeded constructors even without initializer list, even at minimal optimization `-O1`. This is trivial case though, there...

I had a look, the problem is as described in some of the topics you linked. There are two issues that typically cause this kind of thing: * Geometric gaps...

While I'm not sure this is actionable from a code perspective (a contributor might get around to padding grid atlases, or 2D only as in master), it might be good...

Actually, correction, on looking at this case, there does seem to be some interaction with the shader, rather than texture padding. I'm not sure yet, will get back. Yes it...