Laura Brehm
Laura Brehm
That `s.pendingExecs[c] == 0` is there to ensure that we only send the exit event after the **last** exec for the container has been processed. Otherwise that would happen on...
Unfortunately I can't reproduce this :( ```console ⭑ containerd --version containerd github.com/containerd/containerd v1.7.15.m 926c9586fe4a6236699318391cd44976a98e31f1.m ``` After running @bobbypage's repro – ```console ⭑ crictl ps -a CONTAINER IMAGE CREATED STATE NAME...
@bobbypage could you post some containerd debug logs from running your repro? If possible with some extra logs such as with https://github.com/containerd/containerd/commit/511ed30d386fa8fe600959f307b7eb1dccdf3fc1
This is super useful, thanks! I see the init exit being skipped due to pending execs: ``` Aug 19 22:37:24 gke-rapid-default-pool-91865e43-9wka containerd[2080407]: time="2024-08-19T22:37:24.729373934Z" level=debug msg="processExits: skipping exit" container=3a2e74cdcf4c3abf290475aed85b0907be8eeb0b598f0a05ea178f748cbf3e29 pid=2087476 runtime=io.containerd.runc.v2...
Thankyou! Will try to run/see if I can repro. Update: **I can reproduce with this** 🥳
Fwiw, testing with https://github.com/containerd/containerd/pull/10647 (and with https://github.com/containerd/containerd/pull/10651), I see: ```console sudo make integration EXTRA_TESTFLAGS='-run TestIssue10589' + integration INFO[0000] Using the following image list: {Alpine:ghcr.io/containerd/alpine:3.14.0 BusyBox:ghcr.io/containerd/busybox:1.36 Pause:registry.k8s.io/pause:3.10 ResourceConsumer:registry.k8s.io/e2e-test-images/resource-consumer:1.10 VolumeCopyUp:ghcr.io/containerd/volume-copy-up:2.2 VolumeOwnership:ghcr.io/containerd/volume-ownership:2.1 ArgsEscaped:cplatpublic.azurecr.io/args-escaped-test-image-ns:1.0...
The latest in https://github.com/containerd/containerd/pull/10651 might've been bad, sorry! I made some changes/pushed what was missing, but I hadn't tried the no-timeout code yet so it might be broken somewhere. I'll...
Yayyy 🥳 Will close this.
Hiya @qianguih, thanks for the report. I wouldn't think this is a Compose specific issue, but it's possible. Could you test this out with a plain build (`docker build ...`,...
@qianguih > DOCKER_BUILDKIT doesn't work for my current docker setup due to the following: > ``` > DEPRECATED: The legacy builder is deprecated and will be removed in a future...