Laura Brehm

What commit was that on @ningmingxiao? I see: ``` time="2024-09-04T11:42:08.397393639+01:00" level=warning msg="running execs10" runtime=io.containerd.runc.v2 time="2024-09-04T11:42:08.411062400+01:00" level=warning msg="running execs9" runtime=io.containerd.runc.v2 time="2024-09-04T11:42:08.436369821+01:00" level=warning msg="running execs8" runtime=io.containerd.runc.v2 time="2024-09-04T11:42:08.452390740+01:00" level=warning msg="running execs7" runtime=io.containerd.runc.v2 time="2024-09-04T11:42:08.468550166+01:00"...

Opened backports: https://github.com/containerd/containerd/pull/10676 and https://github.com/containerd/containerd/pull/10675.

@ningmingxiao can you explain why the exits are being lost/how this fixes it? The original code skips exit events for init processes for as long as there is a pending...

I also don't really understand your repro instructions: you're adding a `time.Sleep`, for the `!init` case, twice, once before the `lifecycleMu.Lock()` and once after. What does this demonstrate? Trying to...

@ningmingxiao so this happens if you kill the main process while the exec is starting/`preStart` hasn't run yet for the exec? There might be a missing lock/unlock/deadlock issue there, I'm...

Where are the logs for the exec started in https://github.com/containerd/containerd/pull/10603#issuecomment-2293504209?

Does this only happen to you when using `crictl`/pods? Can you reproduce this just creating a container (using `ctr`)? Such as: - `ctr run -d docker.io/library/alpine:latest test top` and ```go...

It's important to try to remove variables to nail down where the issue is. If this isn't reproducible without creating a pod, then it's likely that the issue isn't in...

Thanks! Appreciate the digging in. I'll take a better look at this with more time tomorrow/next week! I think there's definitely an issue, I just don't think this is the...

I see. In that case, there must be some faulty logic in the current implementation. Supposedly, if we get an exit event for the init process while there are pending...