Daniel Espino García

Results 333 comments of Daniel Espino García

@yasserfaraazkhan Any chance you can run the e2e test on CI for this PR and let me know what is failing (that is because of this PR)?

/update-branch

@calebroseland You did the final tweaks to this. Would you be able to help with the cherry-picks?

This may still need changes in the desktop app (0/5) to get the notification through all potential configurations. But otherwise it should work both for web and mobile.

@abhijit-singh Re 1: Sorry, I completely forgot about these. You have them now. The timing I have right now is... - If response comes back in less than 500ms don't...

@abhijit-singh Re Errors: Mostly internal server errors that should never occur, including but not limited to: - Cannot find the bot - Cannot find / create the DM with the...

@devinbinnie I created the following three PRs. When all three are merged, I will merge master into this, and we can re-review. https://github.com/mattermost/mattermost/pull/28857 https://github.com/mattermost/mattermost/pull/28858 https://github.com/mattermost/mattermost/pull/28859

@yasserfaraazkhan I think you have already tested this, but just in case, can you give it a final look before merging?