Daniel Espino García
Daniel Espino García
/update-branch
I added some "background context" to see the elements in the background they are supposed to be shown. This "fix" the issue I was seeing with theming on dark themes,...
@yasserfaraazkhan The only important things to test here is that: - When the developer settings are enabled, the `component_library` endpoint can be navigated to (`baseURL/component_library`) - When the developer settings...
@yasserfaraazkhan This is just refactoring, so there should be no functional change. The idea is test that the front-end of the "Bleve settings" is still doing what it should (show...
@yasserfaraazkhan The error you are seeing is related to the "Index directory" not being accesible by the user that is executing mattermost. I see there is no proper logs about...
/update-branch
@yasserfaraazkhan The failure in playwright seemed to be just flaky. Can you verify before skipping the e2e tests?
@streamer45 You are right. Since the `code-reviewers` is adding two people, I defaulted a bit too much on it. I removed one of the reviewers assigned from `code-reviewers` and added...
@streamer45 Re: test files Short answer: have to be done, but no real plan yet. Long answer: This PR is just a support for a bigger PR, so I didn't...
@streamer45 That sounds great. Actually, I tried to migrate the tests to TS yesterday, and I ended up in this rabbit hole: https://github.com/mattermost/mattermost/pull/28986 When that is merged, we can probably...