Daniel Espino García

Results 339 comments of Daniel Espino García

@yasserfaraazkhan This PR tries to make all the places where Tabs are used to use the same component. There should be no changes from what there was before, but I...

@yasserfaraazkhan 1 is a regression I introduced with the "report a problem" PR. I am looking into it. 2 also doesn't seem related to this PR, so might be another...

@yasserfaraazkhan 1 should be fixed by https://github.com/mattermost/mattermost-mobile/pull/8865 2 I cannot reproduce. Are you trying on a simulator? If so, can you confirm which exact simulator are you using? 3 I...

@yasserfaraazkhan 1 is also happening on main, isn't it? So it is not related to this PR.

@rahimrahman Friendly reminder to do the final review on this one.

@yasserfaraazkhan These e2e tests failures here also don't seem related. Are you ok if I merge this PR?

@yasserfaraazkhan This should only need some smoke test around posting, that nothing seems broken. Probably just running the e2e tests is enough, but I leave that decision to you :smile:

@M-ZubairAhmed No rush. It is a OSF PR and no urgent at all. I would love for you to take a look, but it can be after hacktoberfest.