Daniel Espino García

Results 341 comments of Daniel Espino García

This has been sitting here for too long, and doing a merge now may be too complicated. If we tackle this again, better do it from scratch.

@ldm0330 This may have to do with your language configuration. What exact language have you set in your device?

@enahum What do you think? Should we add a patch on our project, or try to get this upstream? Moment is on maintenance mode, so we might want to consider...

@cpoile I verified all the changes, if I am not mistaken. I am quite confident, but even if I miss something, now that the buttons are more centralized, it should...

@rahimrahman Friendly reminder to review.

@yasserfaraazkhan testing notes: Most of the buttons in the app have been touched. Here is the list of all the buttons based on the files modified: - Buttons shown when...

@yasserfaraazkhan I fixed the disabled styles. Regarding the e2e errors, the search one should be the known issue there. The permalink one is more confusing. The permalink screen shows an...

@abhijit-singh I made some changes (not yet pushed). This is the result: ![image](https://github.com/user-attachments/assets/a39a7942-b8b6-4ce5-8d88-79c5ea08d8b5) The element that holds the playbook name is a bit off because I am using the "Chip"...

Merging this now, since the comments should be addressed, and anything missing is already handled in the details PR.

@M-ZubairAhmed No strong feeling about the location. As long as it is importable from the main product and renderable in the product I am happy with it. Actually, I have...