Allon Moritz comments

Results 343 comments of


                                            Allon Moritz

[5.2] add test for site router (sef)

@heelc29 I contacted you on matermost, if you have time, would be great if you can respond. Anyway, good work!

Chapter about removed db view properties

But not in the migration document to 6.0. This should be another pr.

[6.0] Move CMS Filesystem package to compat plugin

Please move the "classes" folder outside of the src folder. Like it is now you have the src folder managed by a classloader and then the "classes" folder managed by...

[6.0] Tags: Adding associations

Thank you for your contribution, unfortunately the 4.4-dev branch doesn't get new features. When #40181 is merged this pr should be rebased to 5.0-dev. Thanks for understanding.

[5.3] Add missing MVCFactoryInterface into model constructors

Can you fix the conflict here?

[5.3] Add missing MVCFactoryInterface into model constructors

Thanks!

[5.3] Add Files folder to Media component and to "FileSystem local" adapter

I really like it, just the name is for me too generic. I would rather go with documents, if you name them files, then should the images also be moved...

[5.3] Add Files folder to Media component and to "FileSystem local" adapter

Please do not merge till there is an agreement in production about our future folder strategy.

[6.0] CMSPlugin: use Lazy Object feature

As said already, this should be done in the DI container and not every plugin itself should implement this. Or do you see problems when the DI container does that?

[6.0] CMSPlugin: use Lazy Object feature

Similar cod you have in the service provider, I would do here https://github.com/joomla-framework/di/blob/3.x-dev/src/ContainerResource.php#L160.