Allon Moritz comments

Results 343 comments of


                                            Allon Moritz

Add title attribute to default UI input for access

Thank you so much for this fix. Any idea when this will be shipped as official release?

Add title attribute to default UI input for access

Awesome!

[5.2] Fix Postgres Problem in our testing

Do we still need this one as #44324 fixes the problem?

[5.3] Add PluginHelper::getPlugins() and deprecate old behavior

When I see this code, then the plugin should either be booted or the PluginsModel should be used instead of introducing another static function with deprecated global static Factory calls.

Fix `content-type` header to `application/json`

Can you reference the pr which fixed this issue already in 5. The change here is a BC break, so not sure if the need to fix it weight's higher...

Fix `content-type` header to `application/json`

Problem is that this behavior did exist now for a long time. Changing it in a patch release might cause unexpected issues in extensions using that class as it belongs...

[5.2][Events] Use event classes for Sampledata plugins

Thanks!

updateObject method in DatabaseDriver.php always returns true

I would always go for exceptions.

[5.4] Error handling: Adding new shouldUseException()

What would also be good if you can change one occurrence in a core component to this. So extension developers get an idea what to do.

[cypress] Using NPM Module 'pg' for 'postgres'

At the time I implemented Postgres into the system tests, there was a reason why I didn't use pg, but can't remember anymore.