joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.3] Add missing MVCFactoryInterface into model constructors

Open Denitz opened this issue 1 year ago • 2 comments

Summary of Changes

There are models which don't unitilize the MVCFactoryInterface $factory constructor argument for calling parent's constructor.

This results to useless extra calls to Factory::getApplication()->bootComponent() in BaseDatabaseModel::__construct.

Testing Instructions

Apply patch, ensure no errors on actions with patched models.

Actual result BEFORE applying this Pull Request

Model constructors are missing MVCFactoryInterface $factory argument.

Expected result AFTER applying this Pull Request

All good.

Link to documentations

Please select:

  • [x] Documentation link for docs.joomla.org:

  • [x] No documentation changes for docs.joomla.org needed

  • [x] Pull Request link for manual.joomla.org:

  • [x] No documentation changes for manual.joomla.org needed

Denitz avatar Oct 17 '24 14:10 Denitz

Looks good to me, but I would make this for 5.3 and not for 5.2. Would give us some more time to test and be sure we don't have unexpected side effects.

rdeutz avatar Oct 17 '24 17:10 rdeutz

@rdeutz Great, rebased to 5.3-dev

Denitz avatar Oct 18 '24 05:10 Denitz

Can you fix the conflict here?

laoneo avatar Oct 26 '24 04:10 laoneo

@laoneo Resolved.

Denitz avatar Nov 09 '24 10:11 Denitz

Thanks!

laoneo avatar Nov 09 '24 15:11 laoneo