joomla-cms
joomla-cms copied to clipboard
[5.3] Add missing MVCFactoryInterface into model constructors
Summary of Changes
There are models which don't unitilize the MVCFactoryInterface $factory constructor argument for calling parent's constructor.
This results to useless extra calls to Factory::getApplication()->bootComponent() in BaseDatabaseModel::__construct.
Testing Instructions
Apply patch, ensure no errors on actions with patched models.
Actual result BEFORE applying this Pull Request
Model constructors are missing MVCFactoryInterface $factory argument.
Expected result AFTER applying this Pull Request
All good.
Link to documentations
Please select:
-
[x] Documentation link for docs.joomla.org:
-
[x] No documentation changes for docs.joomla.org needed
-
[x] Pull Request link for manual.joomla.org:
-
[x] No documentation changes for manual.joomla.org needed
Looks good to me, but I would make this for 5.3 and not for 5.2. Would give us some more time to test and be sure we don't have unexpected side effects.
@rdeutz Great, rebased to 5.3-dev
Can you fix the conflict here?
@laoneo Resolved.
Thanks!