joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard
verified publisher icon joomla

[5.2] add test for site router (sef)

Open heelc29 opened this issue 1 year ago • 3 comments

Summary of Changes

add tests for site router (sef) and should cover:

  • #42702
  • #42704
  • #42850
  • #42854

Testing Instructions

drone code review

Actual result BEFORE applying this Pull Request

no sef tests

Expected result AFTER applying this Pull Request

test coverage

Link to documentations

Please select:

  • [x] No documentation changes for docs.joomla.org needed
  • [x] No documentation changes for manual.joomla.org needed

heelc29 avatar Oct 14 '24 16:10 heelc29

You can rename the htaccess.txt in beforeEach to .htaccess and in afterEach back to .txt.

laoneo avatar Oct 15 '24 04:10 laoneo

You can rename the htaccess.txt in beforeEach to .htaccess and in afterEach back to .txt.

At the moment I'm struggle a bit with copying/renaming the file.

heelc29 avatar Oct 15 '24 16:10 heelc29

It looks like mod_rewrite is not enabled in docker image.

heelc29 avatar Oct 15 '24 19:10 heelc29

Ready for review

heelc29 avatar Oct 28 '24 08:10 heelc29

@heelc29 I contacted you on matermost, if you have time, would be great if you can respond.

Anyway, good work!

laoneo avatar Oct 30 '24 07:10 laoneo