Marc Lanctot

Results 367 comments of Marc Lanctot

Most importantly, I'd like the following question answered: would we be adding this because it's cool and hip, or is there currently something that can't be done without it? (E.g....

Thanks. If e.g. uv is so popular that it's a candidate to replace pip, then that would change my stance, of course. So, simultaneously, I will look into it.

Wow, this is amazing, thank you! We're a bit back-logged at the moment, so apologies upfront: it will take a bit of time for us to look into this, but...

As discussed in #1376 is it easy enough to change the params in the JAX version as well and check that it works on Kuhn poker in that setting?

Apparently `universal_poker` is also in this category now too. I did not exclude it in #1372 because I had not noticed.. but we should get that one down too. https://github.com/google-deepmind/open_spiel/actions/runs/18139703107/job/51627271436

> Hi [@lanctot](https://github.com/lanctot) , does it happen only today (or yesterday)? I note that [[email protected]](https://github.com/JuliaLang/julia/releases/tag/v1.12.0) just got released yesterday. I'm not sure if it's related or not. If so, maybe...

Just a note that https://github.com/google-deepmind/open_spiel/pull/1380 (which includes https://github.com/google-deepmind/open_spiel/pull/1379) should fix this. Will resolve when those are merged.

Wow thanks @Shafwansafi06 , this looks great! It'll take a little while to properly review so please allow a few days.

Somehow there are files (submodules) included in the commit that shouldn't be: https://github.com/google-deepmind/open_spiel/pull/1390/files#diff-64de6575a4b1b90a783e0e7b5a6f13dd33240ebba27747a48c01edb5c96cec88 This PR should contain only two files at most: - Your new documents - Changes to .gitignore...