Marc Lanctot
Marc Lanctot
Thanks @Ayah-Saleh ! Based on the test and description, I suspect that you forgot to include changes to to `tic_tac_toe.h` and `tic_tac_toe.cc`. Can you add them to the PR?
Also can you take a quick look at this: https://github.com/google-deepmind/open_spiel/issues/1254#issuecomment-2379127019. Curious to get your thoughts.
Hello, thanks for this! We will be including something similar in the new core API in OpenSpiel 2.0 so I will close this one for now. Key your eye out...
Hi @i-Madsen That sounds about right to me, but I will give a bit of advice: those observation tensor functions are the most difficult ones to implement. Leave them until...
Hi @i-Madsen , yes, that sounds very reasonable to me! And using the Bridge functions as a reference is good. You can also check out Hearts, Skat, and Dou Di...
Great! Well, I think some Spades-specific tests would be nice, but I'd say turn it into a PR if you're willing to contribute. Would be great to make it into...
Hi @i-Madsen, The information state string is only used by tabular methods like CFR and XFP. I think what you you need to add the InformationStateTensor function for use with...
Hi @i-Madsen Sorry for the delay in response. For the first message: that is strange, can you confirm that you are running `make` in the build directory and that the...
Ah right, good. I didn't remember if NFSP used the RL environment or bypassed it. In that case you are right, no need for the flag because the RL environment...
Thanks for your contributions. Closing now due to resolution. Please re-open if you need to discuss further!