lance6716 comments

Results 444 comments of


                                            lance6716

lightning: reduce the "unable to get keyspace name" log level to DEBUG

/cc @GMHDBJD @D3Hunter

lightning: reduce the "unable to get keyspace name" log level to DEBUG

/hold wait to address comment

[Limitation] TiCDC can't not handle DDL as `alter table xx add column xx datetime default current_timestamp` properly

if it's caused by different value of `current_timestamp ` in upsteam and downstream, it should be able to fix like https://github.com/pingcap/tiflow/pull/7036

[Limitation] TiCDC can't not handle DDL as `alter table xx add column xx datetime default current_timestamp` properly

In https://github.com/pingcap/tiflow/pull/7036 we also changed `TIME_ZONE`, please check if it's also needed

syncer(dm): option for explicit auto-id-cache handling in create table DDLs

/ok-to-test

syncer(dm): option for explicit auto-id-cache handling in create table DDLs

/retest

syncer(dm): option for explicit auto-id-cache handling in create table DDLs

/retest

syncer(dm): option for explicit auto-id-cache handling in create table DDLs

ptal @D3Hunter @GMHDBJD @OliverS929

use golang built-in functions rather than mathutil

/assign @Anudhyan

use golang built-in functions rather than mathutil

> @lance6716 when will this be reviewed? I'll take a look at Monday