tidb icon indicating copy to clipboard operation
tidb copied to clipboard

lightning: reduce the "unable to get keyspace name" log level to DEBUG

Open kennytm opened this issue 1 year ago • 7 comments

What problem does this PR solve?

Issue Number: close #54232

Problem Summary: When the keyspace-name is empty (default), and the user connecting to downstream TiDB is not a superuser, there will be a confusing "access denied" warning requesting CONFIG privilege. This confuses users to think that this privilege is actually required.

What changed and how does it work?

Just reduce the log level to DEBUG.

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [x] Manual test (add detailed scripts or steps below)
  • [ ] No need to test
    • [ ] I checked and no code files have been changed.

Side effects

  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Breaking backward compatibility

Documentation

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

kennytm avatar Jun 26 '24 09:06 kennytm

Hi @kennytm. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow[bot] avatar Jun 26 '24 09:06 tiprow[bot]

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 56.4606%. Comparing base (2b6595d) to head (3cc68ff). Report is 16 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54243         +/-   ##
=================================================
- Coverage   72.8358%   56.4606%   -16.3752%     
=================================================
  Files          1533       1682        +149     
  Lines        436130     622297     +186167     
=================================================
+ Hits         317659     351353      +33694     
- Misses        98825     246774     +147949     
- Partials      19646      24170       +4524     
Flag Coverage Δ
integration 38.3353% <33.3333%> (?)
unit 71.8217% <100.0000%> (-0.0111%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5848% <ø> (+6.4752%) :arrow_up:

codecov[bot] avatar Jun 26 '24 09:06 codecov[bot]

/cc @GMHDBJD @D3Hunter

lance6716 avatar Jun 27 '24 02:06 lance6716

[LGTM Timeline notifier]

Timeline:

  • 2024-06-26 09:56:37.065488391 +0000 UTC m=+799923.550977221: :ballot_box_with_check: agreed by lance6716.
  • 2024-06-27 06:52:10.082562214 +0000 UTC m=+875256.568051043: :ballot_box_with_check: agreed by GMHDBJD.

ti-chi-bot[bot] avatar Jun 27 '24 06:06 ti-chi-bot[bot]

/hold

wait to address comment

lance6716 avatar Jun 27 '24 06:06 lance6716

/retest

hawkingrei avatar Jun 30 '24 15:06 hawkingrei

PTAL @D3Hunter

kennytm avatar Jul 03 '24 15:07 kennytm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jul 04 '24 04:07 ti-chi-bot[bot]

/unhold

D3Hunter avatar Jul 04 '24 04:07 D3Hunter

In response to a cherrypick label: new pull request created to branch release-8.1: #55053.

ti-chi-bot avatar Jul 30 '24 08:07 ti-chi-bot