8326333: jshell <TAB> completion on arrays is incomplete

[lahodaj]

Inside jshell, arrays don't show Object method in array code completion, i.e.:

jshell> String[] arr = null;
arr ==> null

jshell> arr.<code-completion-here>

will only show length. This patch adds j.l.Object methods to the suggestions for arrays.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8326333: jshell <TAB> completion on arrays is incomplete (Bug - P4)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18163/head:pull/18163
$ git checkout pull/18163

Update a local copy of the PR:
$ git checkout pull/18163
$ git pull https://git.openjdk.org/jdk.git pull/18163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18163

View PR using the GUI difftool:
$ git pr show -t 18163

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18163.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@lahodaj The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (9ce5fb1d)
• 00: Full (e552580b)

[openjdk[bot]]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326333: jshell <TAB> completion on arrays is incomplete

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 115 new commits pushed to the master branch:

• a232e8fb4e6e9e2e9a5285bf01c93b8d1d995f04: 8325621: Improve jspawnhelper version checks
• c879627dbd7e9295d44f19ef237edb5de10805d5: 8309271: A way to align already compiled methods with compiler directives
• 954c50ed88f5daa13d6c7d3cb5910e813c30315c: 8327997: G1: Move G1ScanClosureBase::reference_iteration_mode to subclass
• 6f8b0a33fa15f1dfc8b0c116375df0f90d9d8759: 8327799: JFR view: the "Park Until" field of jdk.ThreadPark is invalid if the parking method is not absolute
• 1d34b74a64fba8d0d58dcbccc416379a4c915738: 8321021: RISC-V: C2 VectorUCastB2X
• 3b9255eb663b4c90aa5cec89f0d9380ef8eba49e: 8325851: Hide PassFailJFrame.Builder constructor
• ad0f329493a73020899640b0815e33ee6d3ea78d: 8327787: Convert javax/swing/border/Test4129681.java applet test to main
• a43c3cc3476f18c048809bcd08f81fc4288ca399: 8327826: Convert javax/swing/border/Test4243289.java applet test to main
• 11a3673d42edbefef70228b4d14595aab11fdac4: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
• 1281e18f1447848d7eb5e3bde508ac002b4c390d: 8325613: CTW: Stale method cleanup requires GC after Sweeper removal
• ... and 105 more: https://git.openjdk.org/jdk/compare/f54e59835492e86b9178b2050901579707f41100...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk[bot]]

Going to push as commit 48717d63cc58f693f0917e61eafd672cd6af02ed. Since your change was applied there have been 157 commits pushed to the master branch:

• ece4124f25f676da9bf2d1b7fd8e4394dd7d31af: 8328247: Remove redundant dir for tests converted from applet to main
• d32ce65781c1d7815a69ceac720cdf3ae39caa9e: 8327651: Rename DictionaryEntry members related to protection domain
• 07194195cefc568048fa639b6f8534ce3718c8d2: 8328236: module_entry in CDS map file has stale value
• 0204aacb0305e94a7d6d5299a5ae835f3f71b030: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d: 8328242: Add a log area to the PassFailJFrame
• 65a84c2642822862fa186f290f8d6e83537bea06: 8328006: refactor large anonymous inner class in HtmlDocletWriter
• 044f4ed55dfce7f1aed9e10accf459b4af9b975e: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
• 71f9c4e7fd5818be6e79dead3caa02d738456ad6: 8320534: fatal error for the NMTBenchmark test run for the mainline build
• bfba4894e14c9547735a6b4ae73ed423af09f0d4: 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
• 42aec8c5e72837400818d931855bade8acad8e9d: 8328146: Set LIBCXX automatically
• ... and 147 more: https://git.openjdk.org/jdk/compare/f54e59835492e86b9178b2050901579707f41100...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@lahodaj Pushed as commit 48717d63cc58f693f0917e61eafd672cd6af02ed.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.