Lars Grüter

Results 496 comments of Lars Grüter

@MarcSkovMadsen sorry for the late response. This sounds like a useful example to have. My only worry is how we would test it and keep it up to date. I'm...

I generally agree with points made in https://github.com/scikit-image/scikit-image/pull/7866#issuecomment-3205533040 directly above. > For example, in SK1Rs warn for `preserve_range` on lines of "skimage2 default behavior corresponds to `preserve_range=True`. To get your...

Nice! Thanks for the literature sleuthing. 😊 Someone tackling this, should probably feel around if and how the new functionality can be easily integrated with the existing algorithm. Speaking from...

From reading previous discussions, I'm wouldn't expect if this is a messy issue to debug. So as a next step I'm planning to close get `main` passing again an closing...

I can see that the clang version changed from 19.1.7 to 20.1.8 between the last passing and failing jobs on `main`. - Passing: [job/50433971025](https://github.com/scikit-image/scikit-image/actions/runs/17746892981/job/50433971025#step:6:26) - Failing: [job/51424769338](https://github.com/scikit-image/scikit-image/actions/runs/18072086753/job/51424769338#step:6:26)

Cython also changed from 3.1.3 to 3.1.4, and meson from 1.9.0 to 1.9.1. I'm not really suspecting meson or other version changes to click, coverage, tifffile, PyYAML, or MarkupSafe.

Looks like this test is even flaky on MacOS. For example see [job/50417237409#step:6:1775](https://github.com/scikit-image/scikit-image/actions/runs/17741768333/job/50417237409#step:6:1775) testing nightly wheels in https://github.com/scikit-image/scikit-image/pull/7901.

Summarizing some context from https://github.com/scikit-image/scikit-image/pull/7684 for future me and others: The failing test relies on `cut_normalized` being deterministic when seeded with the `rng` parameter. However, internally the code makes use...

Done (making use of the new `rng` parameter).

Head's up, I'll merge this maybe by the end of the week in case nobody objects. Should get rid of a few annoyances to the dev workflow. But it would...