Lars Grüter
Lars Grüter
Note I updated this branch with recent changes from `main`. Before you can commit & push any local changes I recommend pulling from this remote branch to your local one....
By the way @decorouz, commit history is looking clean now! :muscle:
Does this also happen if you add a ` # noqa: F401` directly behind the unused import statement?
Then, that should help you push the workaround. :)
Maybe a bit tangential but hopefully still useful: scikit-image is also using a small helper to tackle this problem, see [`assert_stacklevel`](https://github.com/scikit-image/scikit-image/blob/e40e7d91411429b4425e4c75dde18daeda323f11/skimage/_shared/testing.py#L257). While it also uses frame inspection, it can check...
@jni, what do you think about returning a `set` here? I feel like that might also be a very natural fit to communicate that there are no particular guarantees about...
Me neither. I've opened a tracking issue in https://github.com/scikit-image/scikit-image/issues/7491 and we merged a temporary fix (https://github.com/scikit-image/scikit-image/pull/7493) to get our CI working again. Also updated this PR branch to include the...
Nevertheless, thank you @pamitabh for the contribution and the discussions driving this forward! :blush:
Is this ready for review? I feel like we should add a test for this right?
Good question and sorry for the late reply! This might have been an oversight when this function was updated to in #5173 ([#5173 diff](https://github.com/scikit-image/scikit-image/pull/5173/files#diff-416111f9f428520f1811a38817c645ed8407635adc2d0e6879758bab08ce394aR143-R144)). From the [documentation for scipy.ndimage.zoom](https://docs.scipy.org/doc/scipy/reference/generated/scipy.ndimage.zoom.html) I'm...