Christoph Läubrich
Christoph Läubrich
> Let's just remove the call to .beep() But this is actually API behavior :-D I would be fine with removing it but don't want to go the path of...
It depends on the type of action: - `github-action[bot] ` is usually used with default (simple) permissions - `eclipse-platform-bot` is used when elevated permissions are required (using a PAT) I...
Need to check if refactoring of e4 actually happen in platform repository :-\
> I only changed the commit text, the rest LGTM ✔️ > > Any objections with merging this for M3 @laeubi / @BeckerWdf ? We are already at RC1 (see...
@deepika-u I still think it is better fixed at the caller side than in this particular method, so in what cases can it really happen that it is called from...
> But during application or bundle shutdown, destroy() can be invoked from OSGi/framework threads (non-UI). That’s exactly how the reported NPE occurred. I think you should find out where exactly...
In the log I can only see errors about already disposed part / device but not any access from another thread?
> > In the log I can only see errors about already disposed part / device but not any access from another thread? > > yes exactly now with these...
> I have tried running /org.eclipse.e4.ui.tests.css.swt/src/org/eclipse/e4/ui/tests/css/swt/CTabItemTest.java locally to reproduce the NPE And was this successful? Sorry to ask but its a bit unclear to me if the problem is currently...
@deepika-u now we have - https://github.com/eclipse-platform/eclipse.platform.ui/pull/3241 is this PR actually needed?