Christoph Läubrich

Results 1628 comments of Christoph Läubrich

> The `bnd-maven-plugin` contributes its own Eclipse m2e mapping. So I'm not for sure why the pde-connector contributed mapping is ever needed. So why is `bndtools.m2e` then 'ever needed'? :-)...

> the configurator also makes sure to sync markers on java types and packages, bnd, bndrun files etc, at the end of every build operation. You might want to make...

> We don't make the source file. Thanks for the feedback, yes currently no source is created that's what this issue is about :-) > We just generate the class...

Maybe there are better ways to "silence" the compiler (which one?) instead of pulling in everything?

@bjhargrave (or any other committer) would it be possible to approve the workflow run to see if this breaks anything?

The rerun currently fail for some test-cases with: ``` java.lang.NoClassDefFoundError: org/junit/Assert at aQute.xlaunchpad.LaunchpadConfigurationTest.testConfiguration(LaunchpadConfigurationTest.java:50) Caused by: java.lang.ClassNotFoundException: org.junit.Assert not found by biz.aQute.launchpad.tests [9] at org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1597) ``` any hint whats going on?...

@rotty3000 can you maybe take a look at this as this would fix some of the issues with JPMS generation as well and would be the basis for other enhancements.

@rotty3000 maybe you can approve the workflow run in the meanwhile and maybe help with the `CodeQL` and rerun issue?

@rotty3000 Thanks! Any idea where/what need to be adjusted to make the CodeQL happy? DO you have a hint what might be wrong with the "rerun" job? I don't really...

> Code QL infractions are here I have never used Code QL before so these messages are a bit mysterious for me, is there a config file or something for...