Christoph Läubrich

Results 1889 comments of Christoph Läubrich

> Do you have an idea how one could write a good test for it? With a new implementation for InputStream for which available() method returns always 0, maybe? Yes...

@piotrkot As mentioned there are other issues as well se for example https://github.com/yegor256/takes/pulls/laeubi and some of the issues I reported / commented. > That means RqLive can actually contain multiple...

> As for "proper content-length or chuncked encoding", I would prefer to resolve them in other PR. You cant implement proper keep alive according to HTTP1.1 because that is a...

> According to the specs: "In order to remain persistent, all messages on a connection need to have a self-defined message length". This is clear for POST messages. But what...

@piotrkot two things: 1. The server is in control! So if the server things it do not likes to wait any longer, it is allowed to close the connection. One...

@hjohn it might be related to - https://github.com/eclipse-platform/eclipse.platform.swt/issues/2166 or similar, if the label is not stretched to full length it might change for a short period of time. If one...

Is then the problem not that the dialog is not disposed correctly?

@vorobii-vitalii As you noticed using the `isAvailable` for anything really is unreliable I wonder where/who it is used, maybe one better fix that place to not use `isAvailable` at all...

> I agree that relying on BufferedInputStream#available is a bad idea, since it returns estimate. It does not, per javadoc it *might* return an estimate it is also legal to...

@hierynomus there is already a testcase in this PR, @vorobii-vitalii does this testcase fails without your patch?