eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

ContentProposalAdapter should have a way to prevent the beep when programatically open the popup

Open laeubi opened this issue 3 months ago • 5 comments

ContentProposalAdapter#openProposalPopup() currently has (documented) behavior to emit a "beep sound" if it can not open because there are no proposals.

It would be good to let the caller choose to suppress that.

The simplest would be to just make ContentProposalAdapter.openProposalPopup(boolean) public and rename the parameter autoActivated to beep

laeubi avatar Oct 10 '25 08:10 laeubi

Let's just remove the call to .beep()

mickaelistria avatar Oct 10 '25 09:10 mickaelistria

and rework the documentation

mickaelistria avatar Oct 10 '25 09:10 mickaelistria

Let's just remove the call to .beep()

But this is actually API behavior :-D

I would be fine with removing it but don't want to go the path of "it worked like this since 20 years!!!"

laeubi avatar Oct 10 '25 09:10 laeubi

But this is actually API behavior :-D

Let's bring this discussion to the mailing-list. If all people on the ML find it acceptable to change the behavior, it should be fine to do so.

mickaelistria avatar Oct 10 '25 10:10 mickaelistria

An (annoying) beep cannot be API, +2 for removing this.

vogella avatar Oct 10 '25 11:10 vogella