Christoph Läubrich

Results 1600 comments of Christoph Läubrich

@SougandhS also not directly related but can we maybe add an icon to the find menu item= it looks a bit misplaced as it is the only one without one.

@jukzi please read the PR description for what case this is meant: > If a workspace search is allowed to search in binary files, So this is for the case...

If you run the build you get these artifacts (as of today): 1. `org.eclipse.lemminx-0.28.1-SNAPSHOT.jar` that is a bundle and what I'm referring/changing here 2.` org.eclipse.lemminx-0.28.1-SNAPSHOT-tests.jar` that includes the tests 3....

The idea is to make the dependency requirements of the bundle less a concern and at some point make the uber-jar not required for usual deployments especially the ones you...

I recently build a very simple REST interface, and actually one can combine `TkRegex` with `TkMethods` even though its not very obvious, but in the end fits quite well into...

@vogella I'm not sure M3 week is the best to activate new cleanups (as there is less time to fix issues then), maybe it is better to wait for start...

> No suggestion at the moment I'm not sure what to suggest, last time you opened a PR with some cleanups applied and I suggested to do it automatically instead....

> I'm not aware of such a clean-up. If we do please let me know which one it is. See for example here: - https://github.com/eclipse-platform/eclipse.platform.ui/pull/3515 in general I think we...

Another example: - https://github.com/eclipse-pde/eclipse.pde/pull/2058

> Simplify lambda expression is not yet enabled? You get a textual representation of whats enabled when you look at any of the cleanup PRs https://github.com/eclipse-platform/eclipse.platform.ui/pulls?q=is%3Apr+label%3Acleanup+is%3Aclosed > Configuration for the...