eclipse.platform icon indicating copy to clipboard operation
eclipse.platform copied to clipboard

Enhance 'Find' context in Expression View

Open SougandhS opened this issue 3 weeks ago β€’ 6 comments

Make 'Find' context in Expressions view appears only when valid expressions exist.

Before : image

After : image

image

SougandhS avatar Nov 14 '25 05:11 SougandhS

@SougandhS also not directly related but can we maybe add an icon to the find menu item= it looks a bit misplaced as it is the only one without one.

laeubi avatar Nov 14 '25 06:11 laeubi

@SougandhS also not directly related but can we maybe add an icon to the find menu item= it looks a bit misplaced as it is the only one without one.

Sure, will add one πŸ‘

SougandhS avatar Nov 14 '25 06:11 SougandhS

Test Results

 1β€ˆ953 files  Β±0   1β€ˆ953 suites  Β±0   1h 22m 39s ⏱️ - 2m 0s  4β€ˆ744 tests Β±0   4β€ˆ720 βœ… Β±0   24 πŸ’€ Β±0  0 ❌ Β±0  14β€ˆ232 runsβ€Š Β±0  14β€ˆ050 βœ… Β±0  182 πŸ’€ Β±0  0 ❌ Β±0 

Results for commit 8349b0e8. ± Comparison against base commit b0bbf457.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 14 '25 06:11 github-actions[bot]

Added find icon image

SougandhS avatar Nov 14 '25 06:11 SougandhS

Not sure why didn't you also disable "Copy Expressions" for same reason?

iloveeclipse avatar Nov 14 '25 22:11 iloveeclipse

Not sure why didn't you also disable "Copy Expressions" for same reason?

All the VirtualCopyToClipboardActionDelegate implementations have the same issue, showing copy bp, copy stack.. etc on empty selection, I will fix that in another PR.

SougandhS avatar Nov 14 '25 23:11 SougandhS