Embed the google cache dependency in the bundle

[laeubi]

Guava is known as a bit "problematic" dependency, as lemminx only uses guava-cache, this can be embedded in the bundle and be made embedded package.

This changes the used felix-bundle to bnd-maven-plugin with the conditionalpackage to include the caching api in the generated bundle.

FYI @mickaelistria I just choose this a startingpoint because with

• https://github.com/eclipse-lemminx/lemminx/pull/1702

this type does not appear in any public (exported) API anymore, if it could be agreed that this is a way to go I'll try to identify other possible types to embed as well.

[mickaelistria]

Can you please clarify what is "the bundle" here? Is it the uber-jar?

[laeubi]

If you run the build you get these artifacts (as of today):

1. org.eclipse.lemminx-0.28.1-SNAPSHOT.jar that is a bundle and what I'm referring/changing here 2. org.eclipse.lemminx-0.28.1-SNAPSHOT-tests.jar that includes the tests
2. org.eclipse.lemminx-uber.jar includes all dependencies

[mickaelistria]

I would rather not touch the default artifact/bundle as the proposal is adding some complexity while the artifact/bundle is itself working well. If the story is still to improve consumption of lemminx in wild web developer, can't such tweaks only take place in the uber-jar ?

[laeubi]

The idea is to make the dependency requirements of the bundle less a concern and at some point make the uber-jar not required for usual deployments especially the ones you mentioned here

[...] may fail in other deployments because of undocumented dependency ranges. In the current state, LemMinX is totally unable to support such "exotic" deployments. Some LemMinX deps are/were not OSGi-ready

So even though google-cache is OSGi it falls in the first category and always produces some interoperability problems if someone uses a quite narrow range. As it is not part of any public API its a good candidate for embedding (see rationale here) and as everything is automatically handled by BND in this case I don't see much complexity (for the developers/users)

while the artifact/bundle is itself working well.

Can you give examples where lemminx bundle is actually used inside an OSGi deployment?

If the story is still to improve consumption of lemminx in wild web developer, can't such tweaks only take place in the uber-jar ?

The problem is that the uber-jar includes much more I also found here:

• https://github.com/eclipse-lemminx/lemminx/pull/1701

that even a very simple approach requires never maven, maybe even never build JVM, even though it might be solvable.

So currently I somehow tend to maybe make the "real" bundle more easily deployable and less exposed to some kinds of dependency issues (e.g. embedd as much as possible at that stage already).