Lukas Spirig comments

Results 77 comments of


                                            Lukas Spirig

[@lit-labs/ssr, @lit-labs/nextjs] SSR breaks with svg title tag

Thanks for the quick answer and workaround. I'll try it out.

[@lit-labs/ssr, @lit-labs/nextjs] SSR breaks with svg title tag

In this specific instance, I was able to solve it via ``.

Link role not read using Tab navigation

We have reverted our implementation, to align with the given guidelines. This in turn results in being unable to use id references for aria attributes. We are deeply disappointed in...

fix(sbb-time-input, sbb-datepicker): create get/set for valueAsDate

I think for the short term this is ok. It is not an attribute, but just a property. Once we attempt the refactoring for the native form support, we can...

feat: search-overlay page

I checked with @mcilurzo and he had the following feedback: - The content (less padding) is drawn across the entire width of Ultra + instead of just on the grid...

feat: search-overlay page

@federicoisepponfincons Can this be merged?

feat: search-overlay page

Pending discussion with @mcilurzo

fix: avoid minifying identifiers to support SWC/next.js minifier

I have reservations about this. This is fine, if there are no possible workarounds, but we will challenge this first.

perf(sbb-datepicker): dateParser gets called too many times

I'm tempted to postpone this until our framework migration, with which valueAsDate can be directly used.

Use platform `Intl` APIs in Angular's i18n subsystem

I think this is the right direction for all the listed reasons. 👍 Would it still be possible to customize e.g. date formats/logic? To explain; Switzerland has four national languages...