Lukas Spirig
Lukas Spirig
> Thank you so much for this work! Sorry for the very long delay in review. No problem, thanks for the review 😃 > So from my recollection of the...
@bennypowers Thanks for the input. 😃 👍 I did consider tsx/esbuild, but went with swc due to the Node.js alignment.
@augustjk To unblock this PR, I could split the TypeScript part into a separate PR. I only implemented the TypeScript part, as it was requested during a community call.
@augustjk Done. Please have another look.
~~@augustjk The build seems to crash due to an issue in packages/labs/signals, which I doubt is caused by this change. Do you have an idea as to why?~~
@augustjk The breaking build was only a problem locally, from a previous state, after the rebase. Should work fine as it is.
@sorvell In the initial SSR events PR you asked for a tree representation for the event path; I tried to add this here: https://github.com/lit/lit/blob/f4d202c8e1391459a67a43a927f1e015b4bc21e2/packages/labs/ssr-dom-shim/src/lib/events.ts Is this what you were asking...
Hello @patrickuhlmann Not at the moment. I would need to familiarize myself with nx, which I do not have the capacity at the moment. I am however not opposed if...
Hello @mcblTel According to the HTML specification (and in turn semantic meaning), having a button inside a heading element is allowed. Which accessibility rules are you referencing?
We will have a look at this. However, I suspect that fixing this will require breaking changes. As the window for breaking changes for version 3.0 is closing, I think...