lyne-components icon indicating copy to clipboard operation
lyne-components copied to clipboard

feat: search-overlay page

Open federicoisepponfincons opened this issue 2 years ago • 5 comments
trafficstars

Preflight Checklist

Issue

This PR Closes #

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • added the search-overlay page

Browsers

I tested the build on the following browsers:

  • [ ] Firefox Desktop
  • [ ] Chrome Desktop
  • [ ] Edge Desktop
  • [ ] Safari Desktop
  • [ ] Chrome Mobile
  • [ ] Safari Mobile

Screen readers

I tested the build on the following browsers:

  • [ ] JAWS Firefox Desktop
  • [ ] JAWS Chrome Desktop
  • [ ] NVDA Firefox Desktop
  • [ ] NVDA Chrome Desktop
  • [ ] VoiceOver Safari Desktop
  • [ ] VoiceOver Chrome Desktop
  • [ ] VoiceOver Safari Mobile
  • [ ] Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [x] Other (please describe): added page for specific search overlay usage

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

federicoisepponfincons avatar Jun 15 '23 13:06 federicoisepponfincons

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

codecov-commenter avatar Jun 15 '23 14:06 codecov-commenter

I checked with @mcilurzo and he had the following feedback:

  • The content (less padding) is drawn across the entire width of Ultra + instead of just on the grid
  • Distance above to the input is not correct
  • Close button (In the input) is also displayed when the input is empty.
  • Close button (in the input) doesn't seem to work
  • Title "often searched" is missing
  • "Show all 13 results" button is missing
  • Striking, but I wouldn't correct it: The border thickness of the magnifying glass icon is thicker in Florian's designs (like in the header).

kyubisation avatar Jun 30 '23 11:06 kyubisation

@federicoisepponfincons Can this be merged?

kyubisation avatar Jul 24 '23 13:07 kyubisation

Pending discussion with @mcilurzo

kyubisation avatar Jul 25 '23 13:07 kyubisation

I fixed the focus outline for the results

jeripeierSBB avatar Aug 29 '23 09:08 jeripeierSBB