Lukas Spirig

Results 77 comments of Lukas Spirig

As discussed; We leave it as `timetable` for now.

I have created a PR as a base for this issue: #4730 It would be possible to extend the PR to allow an easy configuration for supporting .ts files.

Discussed internally; Currently no hard limit exists for three buttons/links. We will document that fact and adapt the examples to be more flexible (and reduce the amount of examples). Maybe...

> * How to proceed with the loader? How to provide/integrate the loader. I think you answered this by suggesting to add it to `install-global-dom-shim.ts`. > * Should the logic...

I changed the terminology from `loader` to `hook` to align with the terminology used by Node.js

Hello @thescientist13 Can you check whether this PR meets the criteria to close #4862? I have the thought to create a follow-up PR to add an entry/import module `@lit-labs/ssr/dom-shim.js`, which...

> Inferring from the changes in this PR though, would I just simply need to add these lines to the top of my script in the [repro repo](https://github.com/thescientist13/lit-ssr-css-modules/blob/master/index.js)? > >...

@justinfagnani @thescientist13 I implemented a check whether the runtime environment support importing CSS files directly and whether hooks can be registered. Feel free to provide feedback, if you have concerns.

Over the weekend I realized that this implementation will not work, if a consumer uses their own polyfill for `HTMLElement`. If that is a concern (and I feel like it...

@justinfagnani @sorvell Thanks again for your reviews and time. As discussed during our last call, I added tests and comments. Please have another look. Open topics in my mind: 1....