Konrad Windszus

Results 602 comments of Konrad Windszus

Indeed there is an issue with not removing old error markers. I will try to come up with a fix. This is a regression of https://github.com/diffplug/spotless/pull/1962. In addition allowing to...

> Are there cases where Eclipse / m2e performs a non-incremental build and these error markers could still occur inside Eclipse? No, they are only emitted for incremental build >...

Please don’t change the default value for runOnIncremental but rather add a plugin configuration for bailing out on incremental build (similar to what is done in https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/c0433155e825130d1c9a435f5fb837af8e9c46d4/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/mojo/FormatDocviewXmlMojo.java#L110). Newer m2e versions...

@vladbailescu Regarding > thanks again for your contribution, it's very much appreciated! As for next steps: Can you show your appreciation by either allowing this to be committed to contrib...

Any ETA when Cloud Manager will be updated to a more recent Maven version (which is not 4.5 years old)?

I fail to reproduce installation of ACLs not contained in the filter. @anchela Can you come up with a test case?

@tripodsan In general filter rules seem to be followed except for one edge case. What is the idea of `Importer.postFilter` (https://github.com/apache/jackrabbit-filevault/blob/61e920f55e487aa5dc045c66ce5b7b5e444784ca/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L518)? Is that supposed to filter out everything on an...

Look at the test case: It leads to some ACLs being applied although outside the filter, because no subsequent filtering happens. Bug or Feature?

> all ACLs not included in the filter but that are ancestors of the filtered items should be applied. I can follow your argument, but this is not how it...

@reschke Do we again need to introduce a flag for backwards-compatibility where ACLs are applied in some edge cases despite not being contained in the filter?