Feature/video v1

[georgecamilar]

Q	A
Fixed Issues?	Basic Video Component
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass?	Yes
Documentation Provided	Yes (code comments and or markdown)
Any Dependency Changes?
License	Apache License, Version 2.0

Video component written in HTL that renders a video reference using the standard html5 player, with features like autoplay and loop. Also a poster can be used when the video is loading.

[georgecamilar]

Hey, @vladbailescu! Can you please take another look at this pr? I closed my last one and open this one. It is regarding the video component. Maybe you can guide me on what steps should i take next. Thanks a lot!

[codecov[bot]]

Codecov Report

Merging #1624 (deb6f7e) into development (076973a) will increase coverage by 0.14%. The diff coverage is 97.82%.

:exclamation: Current head deb6f7e differs from pull request most recent head eb86fc4. Consider uploading reports for the commit eb86fc4 to get more accurate results

@@                Coverage Diff                @@
##             development    #1624      +/-   ##
=================================================
+ Coverage          86.53%   86.68%   +0.14%     
+ Complexity          2197     2163      -34     
=================================================
  Files                207      207              
  Lines               5869     5798      -71     
  Branches             879      859      -20     
=================================================
- Hits                5079     5026      -53     
+ Misses               321      312       -9     
+ Partials             469      460       -9     

Impacted Files	Coverage Δ
...ts/internal/models/v1/datalayer/VideoDataImpl.java	87.50% <87.50%> (ø)
.../core/components/internal/models/v1/VideoImpl.java	100.00% <100.00%> (ø)
...com/adobe/cq/wcm/core/components/models/Video.java	100.00% <100.00%> (ø)
...cm/core/components/models/datalayer/VideoData.java	100.00% <100.00%> (ø)
.../datalayer/builder/ComponentDataLayerExtender.java	100.00% <100.00%> (ø)
...s/datalayer/builder/VideoComponentDataBuilder.java	100.00% <100.00%> (ø)
.../core/components/internal/models/v2/ImageImpl.java	82.96% <0.00%> (-0.87%)	:arrow_down:
...nts/internal/models/v1/embeddable/YouTubeImpl.java	87.03% <0.00%> (-0.69%)	:arrow_down:
.../core/components/internal/models/v1/ImageImpl.java	86.79% <0.00%> (-0.23%)	:arrow_down:
...com/adobe/cq/wcm/core/components/models/Image.java	100.00% <0.00%> (ø)
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 076973a...eb86fc4. Read the comment docs.

[georgecamilar]

Hey @gabrielwalt ! I created a new pr with corrections of the last code review. On the last pr of the video component, i was told by @vladbailescu that i should ask you about if this is more for contrib repo or for the core component. Also can you please tell me what the next steps are to contributing?

[vladbailescu]

@georgecamilar , thanks again for your contribution, it's very much appreciated! As for next steps:

1. @gabrielwalt to confirm if we should add this here or to the Contrib repo
2. If it will be added to the Core, we'll need to do a bit more thorough review. I had a glance at the code it looks pretty much ok to me.
3. If it will be added to Contrib, I'll arrange you get commit rights there, no need for a more formal review.

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[jkoebner]

@vladbailescu @gabrielwalt any updates as to when we can expect this feature to be added to the core components? would be great to know if this is going to be part of the core components for further planning of the integration of multimedia components. Kind Regards

[kwin]

@vladbailescu Regarding

thanks again for your contribution, it's very much appreciated! As for next steps:

Can you show your appreciation by either allowing this to be committed to contrib or to core components or outline what needs to be changed to somehow get this contribution integrated?

[vladbailescu]

@kwin , we will be taking this into one of our sprints beginning of 2023.