Konrad Windszus

Results 602 comments of Konrad Windszus

Currently the build fails with ``` [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-complete-plugin-classpath) @ aemanalyser-maven-plugin --- [WARNING] Dependency org.osgi:org.osgi.service.configurator:jar:1.0.0 (provided) via org.apache.felix:org.apache.felix.cm.json:jar:1.0.6 not found as runtime dependency! [WARNING] Dependency org.osgi:org.osgi.service.cm:jar:1.6.0 (provided) via org.apache.felix:org.apache.felix.configadmin:jar:1.9.24...

@bosschaert Any opinion/feedback on this PR?

https://github.com/adobe/aemanalyser-maven-plugin/issues/113 is one of the issue which would be solved, but also it checks that the referenced runtime dependencies (those which count during maven plugin execution) have the right version...

> ....which might be tricky to maintain? IMHOn less maintenance effort than always manually going through all transitive provided dependencies to check if some other dependencies need to be made...

You would need to check the current warnings as outlined in https://github.com/adobe/aemanalyser-maven-plugin/pull/164#issuecomment-1172036456.

Well, the issues #176 and #173 show that maintaining the dependencies manually doesn’t really work

The approach of manually maintaining all necessary artifacts does not change at all with this PR. Also more automated tests definitely help. The only thing which is proposed here is...

> I did not know we support the package for the ProviderType ... https://github.com/osgi/bugzilla-archive/issues/2774

> But it basically almost never makes sense to mark a non-interface class as ProviderType unless the class has protected methods which only a subclass could invoke. I think often...

@juergen-albert Could be related but https://github.com/osgi/osgi/issues/643 is broader as it is about multiple levels of inheritance as well.