Konrad Windszus

Results 602 comments of Konrad Windszus

If there is no further concern I would go ahead and merge at the end of this week.

@reschke 59 issues to fix. Do you have capacity to take this over?

``` [ERROR] Forbidden method invocation: java.lang.String#format(java.lang.String,java.lang.Object[]) [Uses default locale] [ERROR] in org.apache.jackrabbit.vault.util.MD5 (MD5.java:100) [ERROR] Forbidden method invocation: java.lang.String#getBytes() [Uses default charset] [ERROR] in org.apache.jackrabbit.vault.util.LineOutputStream (LineOutputStream.java:36) [ERROR] Forbidden method invocation: java.lang.String#toUpperCase()...

If there are no concerns I am gonna merge end of next week @gnodet.

@gnodet I now only emit warning if the URLs differ (https://github.com/apache/maven/commit/cd7aba6af6ff80a394e12b975a293fa07cb813c9) > I think the mapping from an id to a repository URI should actually be defined in the local...

@gnodet I think we should also warn if the URL is equal but the `` flags for either `` or `` differ. Otherwise this might lead to subtle issues which...

> I think we should also warn if the URL is equal but the flags for either or differ. Otherwise this might lead to subtle issues which are hard to...

@gnodet Do we need to keep the old beans in `org.apache.maven.plugin.descriptor` for backwards compatibility or is that not considered public API?

Ok, so when generating descriptor beans in a dedicated package, where should this live? IMHO it doesn't make sense to expose under https://github.com/apache/maven/tree/master/api/maven-api-core. This should rather be a private package...

I would like to migrate all usage of Maven Core from the old `descriptor` to the new `immutabledescriptor` package. But the question is again, do we consider interfaces like https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/plugin/BuildPluginManager.java...