Konrad Windszus
Konrad Windszus
There are already some git based tests, e.g. in https://github.com/apache/maven-release/blob/master/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/RewritePomsForDevelopmentPhaseTest.java#L254-L293. They also verify that my fix isn't introducing regressions for the other providers AFAIK. If you disagree, please let me...
@michael-o Done in https://github.com/apache/maven-release/pull/86/commits/f8825d686adf0e1789726c7dddb1e6dbed3bd98a
At least for single entries this is good enough also to pass from CLI, e.g. `-Daether.connector.http.headers.myrepo="custom-auth-header=customauthvalue"`. Multiple entries are a pain indeed, but should rarely occur. In any case this...
I just figured out by looking at looking at https://github.com/mojohaus/license-maven-plugin/blob/01fd9a1c560fb608e721de0cb1673a29805a40cd/src/main/java/org/codehaus/mojo/license/AbstractLicenseNameMojo.java#L291 that excludes are matched against the relative path below the roots (https://www.mojohaus.org/license-maven-plugin/check-file-header-mojo.html#roots). This is IMHO not obvious at all and...
> why would you like to do parameter testing in an integration test? Because of what I stated in the summary: As Mojo parameter injection is quite complex (especially when...
I would also not change the default but rather document only how to change it. Changing it will lead to regressions for some users, where multiple releases are triggered from...
The old default may be too verbose but will IMHO never lead to a release failure while the new proposed default may fail. Therefore I consider the old default better!
Obviously the installation time is shorter, if you have the npm modules already locally available. But if you start from scratch (i.e. no NPM modules downloaded yet) the time is...
Well I don't use Adobe IO CLI for app development therefore I don't need any `app` commands. Whether you consider a relevant use case or not is a different question
It has been fixed upstream at NVD. Thanks a lot for your help.