aio-cli icon indicating copy to clipboard operation
aio-cli copied to clipboard

Bring down number of dependencies from > 1500

Open kwin opened this issue 3 years ago • 6 comments

When executing npm install -g @adobe/aio-cli with a freshly installed node it downloads 1526(!) dependencies.

+ @adobe/[email protected]
added 1526 packages from 800 contributors in 401.306s

This is insane and takes a lot of time. Please try to bring down the number of (transitive) dependencies down considerably.

kwin avatar Feb 18 '21 20:02 kwin

Hi @kwin , thanks for opening this issue.

Most of the dependencies related to our Core plugins - especially the app one that is used for Firefly applications management.

It is to be fair the first time we receive a feedback with such a long installation time. From our experience, and based on other users feedback, the average is around 60 seconds.

Has it happened once, or do you experience it every time you install a fresh CLI?

meryllblanchet avatar Feb 19 '21 09:02 meryllblanchet

Obviously the installation time is shorter, if you have the npm modules already locally available. But if you start from scratch (i.e. no NPM modules downloaded yet) the time is around 400 seconds. Just try e.g. in a plain docker container.

I would strongly suggest to make app an optional plugin (similar to https://github.com/adobe/aio-cli-plugin-cloudmanager) because Adobe IO CLI is not always used for Firefly.

kwin avatar Feb 19 '21 09:02 kwin

Well this is where we do not necessarily agree - the CLI is a core component from Project Firefly, and the app plugin is a core component of the CLI.

Let me loop in @sarahxxu for her feedback.

meryllblanchet avatar Feb 19 '21 09:02 meryllblanchet

Well I don't use Adobe IO CLI for app development therefore I don't need any app commands. Whether you consider a relevant use case or not is a different question

kwin avatar Feb 19 '21 09:02 kwin

We perfectly understand your current usage, however you also would not need the Console, Runtime or Events plugins, which are part of the Core as well.

So far it is a product decision to have them included OOTB, hence let's ask @sarahxxu 's feedback, as she is my PM counterpart.

meryllblanchet avatar Feb 19 '21 09:02 meryllblanchet

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-1066

aiojbot avatar Feb 19 '21 09:02 aiojbot