Konrad Windszus

Results 602 comments of Konrad Windszus

@mreutegg Any idea why the query in https://github.com/apache/jackrabbit-oak/blob/4dfed10836051aab6d12cd0dc1b022c0745ae8de/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/identifier/IdentifierManager.java#L222 does not find the references in that case?

I would like to add the tests (as I don't think this is covered in the TCK). The behaviour is fine though and fully compliant with JCR 2.0 spec.

@mreutegg Should we use https://jackrabbit.apache.org/jcr/jcr-api.html as target for the JCR 2.0 menu entry instead?

> They confuse "Jackrabbit API" (as the API exposed by all Jackrabbit modules) with the "Jackrabbit JCR Extension API". Please clarify or point me to a documentation where I can...

@smiroslav What should happen with this PR now? It was approved more than three months ago but never merged. Also I see no comment in here or the connected JIRA...

@rombert Any feedback, otherwise I will merge tomorrow?

> does the session contain any modifications after the exception Potentially yes, but that was the case before this patch as well. > adding a {{assertFalse(session.hasPendingChanges()}} should be added to...

> so the import will be incomplete and the next session save would persist the incomplete changes. that sounds pretty dangerous to me. Actually you changed the behaviour in that...

You find an example on how to only inherit one global repository url in https://github.com/digital-wonderland/stash-plugins-jenkins/blob/master/src/main/java/com/atlassian/stash/plugins/jenkins/JenkinsBuildTrigger.java#L52. Maybe we can at least start with just one global repository URL which can be...

I tried with manually setting the parameter `pomElements`. None of `expand`, `keep` or `interpolate` made the parent pom profiles appear in the flattened pom.xml. This is crucial though for using...