Kwankyu Lee

Results 264 comments of Kwankyu Lee

Congrats and thanks! I will revise and rebase this PR to the current base branch soon.

OK. This PR is good to go. Please review.

I was not aware of the test failure. Fixed now.

Can we hope this to be fixed soon? @ClementPernet

fflas-ffpack v2.5.0, with system givaro and openblas, installs fine on my mac following the standard install guide here. I suspect that the reported build failure is caused by peculiar sage...

Is it also good for "health" (or performance)?

It seems that some of `spkg-*.log` files are generated and some not. Which is which and why?

~~Can we test it here, with "CI Fix" tag?~~ We can already see it. I think there should be some explanation why you introduced the log files and why you...

~~You certainly added the logging feature expecting that the logs would be useful.~~ Then now you simply say "which has not proven to be useful". I am curious what happened...

I looked #37391 again. Right, you didn't add the logging feature. As you said, it is a side-effect of using `sage-logger` for prefixing. The generated log files are not useful,...