Kwankyu Lee

Results 264 comments of Kwankyu Lee

I got this: ``` $ sage -t --warn-long 74.7 --random-seed=64827865514850998397057649755024697710 src/sage/databases/findstat.py Running doctests with ID 2024-07-18-10-48-42-56771071. Running with SAGE_LOCAL='/Users/kwankyu/GitHub/sage-dev/local' and SAGE_VENV='/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9' Using --optional=homebrew,pip,sage,sage_spkg Features to be detected: 4ti2,SAGE_SRC,benzene,bliss,buckygen,conway_polynomials,coxeter3,csdp,cvxopt,cvxopt,database_cremona_ellcurve,database_cremona_mini_ellcurve,database_cubic_hecke,database_ellcurves,database_graphs,database_jones_numfield,database_knotinfo,dvipng,ecm,fpylll,fricas,gap_package_atlasrep,gap_package_design,gap_package_grape,gap_package_guava,gap_package_hap,gap_package_polycyclic,gap_package_qpa,gap_package_quagroup,gfan,graphviz,imagemagick,ipython,jmol,jupymake,kenzo,latte_int,lrcalc_python,lrslib,matroid_database,mcqd,meataxe,mpmath,msolve,nauty,networkx,numpy,palp,pandoc,pdf2svg,pdftocairo,pexpect,phitigra,pillow,plantri,polytopes_db,polytopes_db_4d,pplpy,primecountpy,ptyprocess,pynormaliz,pyparsing,python_igraph,requests,rpy2,rubiks,sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.groups,sage.libs.braiding,sage.libs.ecl,sage.libs.flint,sage.libs.gap,sage.libs.linbox,sage.libs.m4ri,sage.libs.ntl,sage.libs.pari,sage.libs.singular,sage.misc.cython,sage.modular,sage.modules,sage.numerical.mip,sage.plot,sage.rings.complex_double,sage.rings.finite_rings,sage.rings.function_field,sage.rings.number_field,sage.rings.padics,sage.rings.polynomial.pbori,sage.rings.real_double,sage.rings.real_mpfr,sage.sat,sage.schemes,sage.symbolic,sage_numerical_backends_coin,sagemath_doc_html,scipy,singular,sirocco,sphinx,symengine_py,sympy,tdlib,threejs Doctesting 1...

This PR is mostly about CI maintenance, pertaining to the proposal: https://groups.google.com/g/sage-devel/c/dEa3i2Fn3ZY As such, I apply "show" model for reviewing this PR (that is, believe the maintainer is doing the...

> Trying to ignore them, mostly. I am not sure if this is desirable. (1) When we search for oeis items for a given sequence, then dead items should be...

All right. I will leave the design to you and @PeterLuschny, as I have had no occasion to use OEIS. I looked through the code, and have no other comments.

```sage sage -t --warn-long 74.9 --random-seed=59529410646860986269150172674114866305 src/sage/schemes/elliptic_curves/hom_composite.py ********************************************************************** File "src/sage/schemes/elliptic_curves/hom_composite.py", line 759, in sage.schemes.elliptic_curves.hom_composite.EllipticCurveHom_composite.rational_maps Failed example: f(*phi.rational_maps(), 1) % g # needs sage.rings.finite_rings Expected: 0 Got: (-x^27 - 16854*x^26 +...

Failures `src/sage/categories/pushout.py` make me doubt if the solution is good...

Perhaps, when you made changes to how doc diffs are made... As far as I remember, It got broken once, and to fix it, I inserted `path = 'html/' +...

If a PR gets "disputed" label, people are expected to vote rather than to review the PR. Hence the author (not the reviewer) should summarize what is the disputed issue...