Kwankyu Lee

Results 264 comments of Kwankyu Lee

I tried again on ubuntu. After successful built of the wheel, I got: ```bash (python312) kwankyu@ubuntu:~/GitHub/sage-dev/pkgs/sagemath-standard/dist$ pip install ./sagemath_standard-10.5b2-cp312-cp312-linux_x86_64.whl ERROR: Exception: Traceback (most recent call last): ... File "/home/kwankyu/Venv/python312/lib/python3.12/site-packages/pip/_internal/utils/urls.py", line...

> I've also noted in #31251 that it would be desirable for lrcalc upstream to publish wheels to PyPI. So all the fuss I went through is unavoidable unless lrcalc...

I see. My venvs are outside of `sage -sh`. There was no problem except `lrcalc`.

The step `pip install lrcalc` was not really necessary. This is the first time that I successfully installed sagemath-standard distribution package. Personally, it is the most impressive product of the...

Perhaps not an issue directly related with this PR, but I wonder if `lrcalc` (and others if any) is a prerequisite of sagemath-standard and if that should be documented somewhere.

> Note that the user-facing documentation of installation with Python tools is in https://github.com/sagemath/sage/blob/develop/README.md#alternative-installation-using-pypi - it provisions the non-Python dependencies via **sage_conf**. So Python dependencies are automatically resolved and installed...

Perhaps another test run of the changed workflows? Otherwise lgtm.

OK, as the changes on the workflows are just additions and can be tested on the battleground.

> This implements the policy for use of platform-dependent wheels proposed in https://github.com/sagemath/sage/pull/38219 ("if a platform-dependent wheel package is a standard package, there must be a configure option that disables...

"disabling standard package" sounds strange but is okay. My question is rather on "must be". Why "must be a configure option" for "platform-dependent wheel"?