Keyhan Vakil

> `Assertion failed: (napi_create_external(env, fseenv, fse_environment_destroy, NULL, &result) == napi_ok), function fse_environment_create, file ../src/fsevents.c, line 87` > I wasn't able to find this file in Node repo. It looks like...

I think that this PR would be a great change. But I also think that `request-ci` should always do the right thing: if there are no commits since the last...

In my mind resume wouldn't happen automatically, the author would still need to go back and retag the PR with `request-ci` in order to resume it. There just wouldn't be...

> > just think the user experience would be better. > > Currently the user experience is to go to the Jenkins Web UI to check what are the failures,...

> I would be reluctant to put a lot of effort into improving performance of a feature when there's a better, faster language built-in already available. We probably should and...

> I think deprecating or discouraging the use of `napi_create_buffer[_copy]()` would be fine. It’s not ever going to go away and it’s not exactly wrong to use the method, so...

I coudln't reproduce on amd64 with gcc 12, so I tagged this as mips/risc-v specific.

Okay, PTAL. I moved the additions into the sub-bullets, which feels better and removes the ambiguity of if `--stack-size` takes effect. If you'd like I can explicitly note that `--stack-size`...

I created https://github.com/nodejs/node/pull/44093 to start the deprecation process & for further discussion.

Forgot to mention that the graph view looks correct.  The disasm view is similarly broken: ``` (pprof) disasm fac Total: 2.43s ROUTINE ======================== main.fac...