Keyhan Vakil

It fails with this error: ``` Warning: Unexpected input(s) 'node-mirror', valid inputs are ['always-auth', 'node-version', 'architecture', 'check-latest', 'registry-url', 'scope', 'token', 'cache', 'cache-dependency-path', 'version'] Run No9/setup-node@mirror Attempting to download 19.x... Not...

> You'll need to add deps/zlib to the right `include_dirs` directives in tools/v8_gypfiles/v8.gyp and possibly other build files in said directory. thanks. Fixed in the latest iteration. > If Windows...

Hm. Perhaps we can `cp -r deps/zlib deps/v8/third_party/zlib` (or symlink) in `tools/make-v8.sh`, and that might be enough? Will give it a go tomorrow.

I can't reproduce on Debian with gcc-13.1.0: ```console $ gcc-13 --version gcc-13 (Debian 13.1.0-3) 13.1.0 Copyright (C) 2023 Free Software Foundation, Inc. This is free software; see the source for...

> Whatever is failing here appears to be happening after several seconds in a non-main thread. My suspicion is that the tests aren't active long enough for whatever that other...

Thanks all. I'm fine with the change only landing on the release branch. I fixed the spurious newline which snuck in somehow.

> The build after v21 seems broken. https://unofficial-builds.nodejs.org/download/release/v21.1.0/node-v21.1.0-linux-x64-pointer-compression.tar.xz The build was broken by the V8 update. I put up a fix here: https://github.com/nodejs/node/pull/50680